Messages in this thread | | | From | Sami Tolvanen <> | Date | Tue, 8 Oct 2019 15:18:42 -0700 | Subject | Re: [PATCH] x86: use the correct function type for native_set_fixmap |
| |
On Tue, Sep 24, 2019 at 12:51 PM Sami Tolvanen <samitolvanen@google.com> wrote: > Someone else probably knows better, but yes, we could also fix this by > changing set_fixmap to accept enum fixed_addresses as the first > parameter, and changing the type of xen_set_fixmap instead.
This approach is actually more problematic since we cannot forward declare an enum in C and including <asm/fixmap.h> here results in a ton of other missing dependencies. I assume this is why the callback function accepts unsigned in the first place.
Sami
| |