lkml.org 
[lkml]   [2019]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] proc:fix confusing macro arg name
On 2019-10-08, linmiaohe <linmiaohe@huawei.com> wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch
> Alexey Dobriyan <adobriyan@gmail.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@vger.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@vger.kernel.org (open list:PROC FILESYSTEM)
>
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@huawei.com>
> Subject: fix confusing macro arg name
>
> state_size and ops are in the wrong position, fix it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Looks reasonable.

Acked-by: Aleksa Sarai <cyphar@cyphar.com>

> ---
>
> include/linux/proc_fs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *); struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
> struct proc_dir_entry *parent, const struct seq_operations *ops,
> unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> - proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> + proc_create_net_data(name, mode, parent, ops, state_size, NULL)
> struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
> struct proc_dir_entry *parent,
> int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
>


--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-10-08 09:28    [W:0.432 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site