Messages in this thread | | | Date | Tue, 8 Oct 2019 08:47:44 -0700 | From | Jerry Snitselaar <> | Subject | Re: [PATCH][next] efi/tpm: fix sanity check of unsigned tbl_size being less than zero |
| |
On Tue Oct 08 19, Colin King wrote: >From: Colin Ian King <colin.king@canonical.com> > >Currently the check for tbl_size being less than zero is always false >because tbl_size is unsigned. Fix this by making it a signed int. > >Addresses-Coverity: ("Unsigned compared against 0") >Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") >Signed-off-by: Colin Ian King <colin.king@canonical.com> >--- > drivers/firmware/efi/tpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c >index 703469c1ab8e..ebd7977653a8 100644 >--- a/drivers/firmware/efi/tpm.c >+++ b/drivers/firmware/efi/tpm.c >@@ -40,7 +40,7 @@ int __init efi_tpm_eventlog_init(void) > { > struct linux_efi_tpm_eventlog *log_tbl; > struct efi_tcg2_final_events_table *final_tbl; >- unsigned int tbl_size; >+ int tbl_size; > int ret = 0; > > if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { >-- >2.20.1 >
Thanks for catching that. Somehow I dropped it from v2 to v3.
| |