[lkml]   [2019]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user()
On Tue, Oct 08, 2019 at 05:57:12AM +0100, Al Viro wrote:
> OK... BTW, do you agree that the use of access_ok() in
> drivers/tty/n_hdlc.c:n_hdlc_tty_read() is wrong? It's used as an early
> cutoff, so we don't bother waiting if user has passed an obviously bogus
> address. copy_to_user() is used for actual copying there...

Yes, it's wrong, and not needed. I'll go rip it out unless you want to?


greg k-h

 \ /
  Last update: 2019-10-08 15:15    [W:0.087 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site