Messages in this thread | | | Subject | Re: [PATCH v2 5/6] rpmsg: glink: Don't send pending rx_done during remove | From | Chris Lew <> | Date | Tue, 8 Oct 2019 18:08:46 -0700 |
| |
On 10/4/2019 3:27 PM, Bjorn Andersson wrote: > Attempting to transmit rx_done messages after the GLINK instance is > being torn down will cause use after free and memory leaks. So cancel > the intent_work and free up the pending intents. > > With this there are no concurrent accessors of the channel left during > qcom_glink_native_remove() and there is therefor no need to hold the > spinlock during this operation - which would prohibit the use of > cancel_work_sync() in the release function. So remove this. > > Fixes: 1d2ea36eead9 ("rpmsg: glink: Add rx done command") > Cc: stable@vger.kernel.org > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > ---
Acked-By: Chris Lew <clew@codeaurora.org>
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |