Messages in this thread | | | From | Zhenzhong Duan <> | Subject | checkpatch error | Date | Tue, 8 Oct 2019 12:02:47 +0800 |
| |
Hi,
When I run checkpatch.pl with a patch doing reverting operation, it reports a false positive error, Should I ignore the error or it's a bug?
0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch --------------------------------------------------------------- ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 090d54bcbc54 ("Revert "x86/paravirt: Set up the v' #14: The similar change for XEN is in commit 090d54bcbc54 ("Revert
total: 1 errors, 0 warnings, 31 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
# cat 0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch From 5d90690ba0476cab223f5e1d13955858b9c91623 Mon Sep 17 00:00:00 2001 From: Zhenzhong Duan <zhenzhong.duan@oracle.com> Date: Mon, 7 Oct 2019 09:20:58 +0800 Subject: [PATCH v5 1/5] Revert "KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized"
This reverts commit 34226b6b70980a8f81fff3c09a2c889f77edeeff.
Commit 8990cac6e5ea ("x86/jump_label: Initialize static branching early") adds jump_label_init() call in setup_arch() to make static keys initialized early, so we could use the original simpler code again.
The similar change for XEN is in commit 090d54bcbc54 ("Revert "x86/paravirt: Set up the virt_spin_lock_key after static keys get initialized"") ...
Thanks
Zhenzhong
| |