Messages in this thread | | | Date | Fri, 4 Oct 2019 10:11:06 +0200 | From | Jan Kara <> | Subject | Re: [PATCH] quota: avoid increasing DQST_LOOKUPS when iterating over dirty/inuse list |
| |
On Thu 26-09-19 16:34:08, Chengguang Xu wrote: > It is meaningless to increase DQST_LOOKUPS number while iterating > over dirty/inuse list, so just avoid it. > > Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
Yeah, makes sense. I've queued up your patch. Thanks!
Honza
> --- > fs/quota/dquot.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index 6e826b454082..00a3c6df2ea3 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -595,7 +595,6 @@ int dquot_scan_active(struct super_block *sb, > /* Now we have active dquot so we can just increase use count */ > atomic_inc(&dquot->dq_count); > spin_unlock(&dq_list_lock); > - dqstats_inc(DQST_LOOKUPS); > dqput(old_dquot); > old_dquot = dquot; > /* > @@ -649,7 +648,6 @@ int dquot_writeback_dquots(struct super_block *sb, int type) > * use count */ > dqgrab(dquot); > spin_unlock(&dq_list_lock); > - dqstats_inc(DQST_LOOKUPS); > err = sb->dq_op->write_dquot(dquot); > if (err) { > /* > -- > 2.20.1 > > > > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |