Messages in this thread | | | Date | Mon, 7 Oct 2019 00:38:48 +0200 | From | Jonathan Neuschäfer <> | Subject | Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file |
| |
Thanks for CCing me on this patchset. Nice to see more e-book reader related work!
A few comments and questions below.
On Mon, Sep 30, 2019 at 09:43:31PM +0200, Andreas Kemnade wrote: > The Netronix board E60K02 can be found some several Ebook-Readers, > at least the Kobo Clara HD and the Tolino Shine 3. The board > is equipped with different SoCs requiring different pinmuxes.
Do I understand it correctly that i.MX6SL and i.MX6SLL are pin- compatible so we can use the same pin numbers and GPIO handles in the DT?
> + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led>; > + > + GLED {
What does "GLED" mean? It's not obvious to me. What user-visible purpose does this LED have, or where is it on the board?
> + gpios = <&gpio5 7 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "timer"; > + }; > + }; > + > + memory { > + reg = <0x80000000 0x80000000>;
2 GiB of memory?
> + /* Core3_3V3 */
What are these labels (Core3_3V3, Core4_1V2, etc.)?
> + dcdc2_reg: DCDC2 { > + regulator-name = "DCDC2"; > + regulator-always-on; > + regulator-boot-on; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-max-microvolt = <3300000>; > + regulator-suspend-min-microvolt = <3300000>; > + }; > + };
Thanks, Jonathan Neuschäfer [unhandled content-type:application/pgp-signature] | |