lkml.org 
[lkml]   [2019]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 038/137] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ]

    In radeon_connector_set_property(), there is an if statement on line 743
    to check whether connector->encoder is NULL:
    if (connector->encoder)

    When connector->encoder is NULL, it is used on line 755:
    if (connector->encoder->crtc)

    Thus, a possible null-pointer dereference may occur.

    To fix this bug, connector->encoder is checked before being used.

    This bug is found by a static analysis tool STCheck written by us.

    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/radeon/radeon_connectors.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
    index de1745adccccb..c7f2e073a82fd 100644
    --- a/drivers/gpu/drm/radeon/radeon_connectors.c
    +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
    @@ -752,7 +752,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct

    radeon_encoder->output_csc = val;

    - if (connector->encoder->crtc) {
    + if (connector->encoder && connector->encoder->crtc) {
    struct drm_crtc *crtc = connector->encoder->crtc;
    struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-06 20:21    [W:3.159 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site