lkml.org 
[lkml]   [2019]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 113/137] PCI: exynos: Propagate errors for optional PHYs
    Date
    From: Thierry Reding <treding@nvidia.com>

    [ Upstream commit ddd6960087d4b45759434146d681a94bbb1c54ad ]

    devm_of_phy_get() can fail for a number of reasons besides probe
    deferral. It can for example return -ENOMEM if it runs out of memory as
    it tries to allocate devres structures. Propagating only -EPROBE_DEFER
    is problematic because it results in these legitimately fatal errors
    being treated as "PHY not specified in DT".

    What we really want is to ignore the optional PHYs only if they have not
    been specified in DT. devm_of_phy_get() returns -ENODEV in this case, so
    that's the special case that we need to handle. So we propagate all
    errors, except -ENODEV, so that real failures will still cause the
    driver to fail probe.

    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: Andrew Murray <andrew.murray@arm.com>
    Cc: Jingoo Han <jingoohan1@gmail.com>
    Cc: Kukjin Kim <kgene@kernel.org>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/dwc/pci-exynos.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
    index cee5f2f590e2d..14a6ba4067fbe 100644
    --- a/drivers/pci/controller/dwc/pci-exynos.c
    +++ b/drivers/pci/controller/dwc/pci-exynos.c
    @@ -465,7 +465,7 @@ static int __init exynos_pcie_probe(struct platform_device *pdev)

    ep->phy = devm_of_phy_get(dev, np, NULL);
    if (IS_ERR(ep->phy)) {
    - if (PTR_ERR(ep->phy) == -EPROBE_DEFER)
    + if (PTR_ERR(ep->phy) != -ENODEV)
    return PTR_ERR(ep->phy);

    ep->phy = NULL;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-06 19:54    [W:2.773 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site