lkml.org 
[lkml]   [2019]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 28/36] net: qlogic: Fix memory leak in ql_alloc_large_buffers
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit 1acb8f2a7a9f10543868ddd737e37424d5c36cf4 ]

    In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb.
    This skb should be released if pci_dma_mapping_error fails.

    Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/qlogic/qla3xxx.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/qlogic/qla3xxx.c
    +++ b/drivers/net/ethernet/qlogic/qla3xxx.c
    @@ -2783,6 +2783,7 @@ static int ql_alloc_large_buffers(struct
    netdev_err(qdev->ndev,
    "PCI mapping failed with error: %d\n",
    err);
    + dev_kfree_skb_irq(skb);
    ql_free_large_buffers(qdev);
    return -ENOMEM;
    }

    \
     
     \ /
      Last update: 2019-10-06 19:21    [W:3.692 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site