lkml.org 
[lkml]   [2019]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: BISECTED: Compile error on 5.4-rc1
On Sat, Oct 5, 2019 at 7:50 PM Harald Arnesen <harald@skogtun.org> wrote:
>
> Masahiro Yamada [05.10.2019 12:19]:
>
> > CONFIG_SHELL previously fell back to 'sh' when bash is not installed,
> > so I just kept it as it was.
> >
> > If we had used the exact absolute path /bin/sh,
> > it would have worked irrespective of the PATH environment.
> >
> > But, there is a counter option like this:
> >
> >
> > commit 16f8259ca77d04f95e5ca90be1b1894ed45816c0
> > Author: Bjørn Forsman <bjorn.forsman@gmail.com>
> > Date: Sun Nov 5 10:44:16 2017 +0100
> >
> > kbuild: /bin/pwd -> pwd
> >
> > Most places use pwd and rely on $PATH lookup. Moving the remaining
> > absolute path /bin/pwd users over for consistency.
> >
> > Also, a reason for doing /bin/pwd -> pwd instead of the other way around
> > is because I believe build systems should make little assumptions on
> > host filesystem layout. Case in point, we do this kind of patching
> > already in NixOS.
> >
> > Ref. commit 028568d84da3cfca49f5f846eeeef01441d70451
> > ("kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)").
> >
> > Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> >
> >
> > I cannot find a way to satisfy everybody.
> >
>
> I'm totally fine with the way it is now, now that I know how it works.
> However, doesn't Posix dictate that there is a /bin/sh?


As for POSIX, I found this:

---------------------->8----------------------------
Applications should note that the standard PATH to the shell cannot
be assumed to be either /bin/sh or /usr/bin/sh, and should be determined
by interrogation of the PATH returned by getconf PATH , ensuring that
the returned pathname is an absolute pathname and not a shell built-in.
---------------------->8----------------------------

https://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2019-10-05 15:19    [W:0.090 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site