Messages in this thread | | | From | Linus Walleij <> | Date | Sat, 5 Oct 2019 00:03:37 +0200 | Subject | Re: [PATCH 3/3] gpio: max77620: Fix interrupt handling |
| |
On Wed, Oct 2, 2019 at 2:28 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> From: Timo Alho <talho@nvidia.com> > > The interrupt-related register fields on the MAX77620 GPIO controller > share registers with GPIO related fields. If the IRQ chip is implemented > with regmap-irq, this causes the IRQ controller code to overwrite fields > previously configured by the GPIO controller code. > > Two examples where this causes problems are the NVIDIA Jetson TX1 and > Jetson TX2 boards, where some of the GPIOs are used to enable vital > power regulators. The MAX77620 GPIO controller also provides the USB OTG > ID pin. If configured as an interrupt, this causes some of the > regulators to be powered off. > > Signed-off-by: Timo Alho <talho@nvidia.com> > Signed-off-by: Thierry Reding <treding@nvidia.com>
Patch applied.
I am looking for ways to pass also nested irqchips along when registering the gpio_chip but I guess I need to clean up all the chained chips first (getting there...)
Yours, Linus Walleij
| |