Messages in this thread | | | Subject | Re: [PATCH] mtd: spi-nor: Fix direction of the write_sr() transfer | From | Vignesh Raghavendra <> | Date | Fri, 4 Oct 2019 21:36:51 +0530 |
| |
On 04-Oct-19 4:17 PM, Tudor.Ambarus@microchip.com wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > write_sr() sends data to the SPI memory, fix the direction. > > Fixes: b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") > Reported-by: John Garry <john.garry@huawei.com> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > ---
Thanks for the quick fix!
Acked-by: Vignesh Raghavendra <vigneshr@ti.com>
> drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 1d8621d43160..7acf4a93b592 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -487,7 +487,7 @@ static int write_sr(struct spi_nor *nor, u8 val) > SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1), > SPI_MEM_OP_NO_ADDR, > SPI_MEM_OP_NO_DUMMY, > - SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1)); > + SPI_MEM_OP_DATA_OUT(1, nor->bouncebuf, 1)); > > return spi_mem_exec_op(nor->spimem, &op); > } >
| |