Messages in this thread | | | Subject | Re: [PATCH v4 3/4] xen: Mark "xen_nopvspin" parameter obsolete | From | Boris Ostrovsky <> | Date | Fri, 4 Oct 2019 10:57:13 -0400 |
| |
On 10/3/19 10:02 AM, Zhenzhong Duan wrote: > Map "xen_nopvspin" to "nopvspin", fix stale description of "xen_nopvspin" > as we use qspinlock now. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: "H. Peter Anvin" <hpa@zytor.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
with a small nit
> void __init xen_init_spinlocks(void) > { > + if (nopvspin) > + xen_pvspin = false; > > /* Don't need to use pvqspinlock code if there is only 1 vCPU. */ > if (num_possible_cpus() == 1)
I'd fold the change into this 'if' statement, I think it will still be clear what the comment refers to.
-boris
| |