Messages in this thread | | | Date | Fri, 4 Oct 2019 12:58:24 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() |
| |
On Thu 03-10-19 13:40:57, Anshuman Khandual wrote: > Having unmovable pages on a given pageblock should be reported correctly > when required with REPORT_FAILURE flag. But there can be a scenario where a > reserved page in the page block will get reported as a generic "unmovable" > reason code. Instead this should be changed to a more appropriate reason > code like "Reserved page".
Others have already pointed out this is just redundant but I will have a more generic comment on the changelog. There is essentially no information why the current state is bad/unhelpful and why the chnage is needed. All you claim is that something is a certain way and then assert that it should be done differently. That is not how changelogs should look like. -- Michal Hocko SUSE Labs
| |