Messages in this thread | | | Date | Thu, 31 Oct 2019 09:41:26 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 3/6] efi/random: treat EFI_RNG_PROTOCOL output as bootloader randomness |
| |
* Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On Tue, 29 Oct 2019 at 20:14, Bhupesh Sharma <bhsharma@redhat.com> wrote: > > > > Hi Ard, > > > > On Tue, Oct 29, 2019 at 11:10 PM Ard Biesheuvel <ardb@kernel.org> wrote: > > > > > > From: Dominik Brodowski <linux@dominikbrodowski.net> > > > > > > Commit 428826f5358c ("fdt: add support for rng-seed") introduced > > > add_bootloader_randomness(), permitting randomness provided by the > > > bootloader or firmware to be credited as entropy. However, the fact > > > that the UEFI support code was already wired into the RNG subsystem > > > via a call to add_device_randomness() was overlooked, and so it was > > > not converted at the same time. > > > > > > Note that this UEFI (v2.4 or newer) feature is currently only > > > implemented for EFI stub booting on ARM, and further note that > > > CONFIG_RANDOM_TRUST_BOOTLOADER must be enabled, and this should be > > > done only if there indeed is sufficient trust in the bootloader > > > _and_ its source of randomness. > > > > > > Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> > > > [ardb: update commit log] > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > Seems my Tested-by was dropped which I provide for the RFC version of > > this patch. > > See <https://www.mail-archive.com/linux-efi@vger.kernel.org/msg12281.html> > > for details. > > > > I can provide a similar Tested-by for this version as well. > > > > Thanks Bhupesh
I've added Bhupesh's Tested-by to the commit - no need to resend.
I've picked up all 6 EFI fixes, will push them out after a bit of testing - sorry about the delay!
Thanks,
Ingo
| |