Messages in this thread | | | Subject | Re: [PATCH v4 01/48] Input: introduce input_mt_report_slot_inactive | From | Henrik Rydberg <> | Date | Thu, 31 Oct 2019 09:01:06 +0100 |
| |
Hi Dmitry,
On 2019-10-31 00:23, Dmitry Torokhov wrote: > On Tue, Oct 29, 2019 at 06:13:09PM +0100, Henrik Rydberg wrote: >> Hi Jiada, >> >>> input_mt_report_slot_state() ignores the tool when the slot is closed. >>> which has caused a bit of confusion. >>> This patch introduces input_mt_report_slot_inactive() to report slot >>> inactive state. >>> replaces all input_mt_report_slot_state() with >>> input_mt_report_slot_inactive() in case of close of slot. >>> >>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com> >> NACK on this one. >> >> We already discussed this patch and the potentially changed behavior to >> existing setups stemming from ignoring the MT state. >> >> On the upside, what I can see this patch does exactly no difference to the >> cases where the MT state is set, so it can be safely dropped without >> affecting the rest of the patch series. > I guess Jiada's concern that we are forcing to pass tool type even > though we end up ignoring it intervally, which confuses users of the API > as they might not know what tool to specify. > > How about we do: > > static inline void input_mt_report_slot_inactive(struct input_dev *dev) > { > input_mt_report_slot_state(dev, 0, false); > } > > This should not change any behavior.
Agreed, that will work.
Thanks,
Henrik
| |