lkml.org 
[lkml]   [2019]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 3/3] net: phy: at803x: add device tree binding
Am 2019-10-31 00:59, schrieb Michael Walle:
>>> +
>>> + if (of_property_read_bool(node, "atheros,keep-pll-enabled"))
>>> + priv->flags |= AT803X_KEEP_PLL_ENABLED;
>>
>> This should probably be a PHY tunable rather than a Device Tree
>> property
>> as this delves more into the policy than the pure hardware
>> description.
>
> To be frank. I'll first need to look into PHY tunables before answering
> ;)
> But keep in mind that this clock output might be used anywhere on the
> board. It must not have something to do with networking. The PHY has a
> crystal and it can generate these couple of frequencies regardless of
> its network operation.

Although it could be used to provide any clock on the board, I don't
know
if that is possible at the moment, because the PHY is configured in
config_init() which is only called when someone brings the interface up,
correct?

Anyway, I don't know if that is worth the hassle because in almost all
cases the use case is to provide a fixed clock to the MAC for an RGMII
interface. I don't know if that really fits a PHY tunable, because in
the worst case the link won't work at all if the SoC expects an
always-on clock.

--
-michael

\
 
 \ /
  Last update: 2019-10-31 18:23    [W:0.498 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site