lkml.org 
[lkml]   [2019]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arm64: apply ARM64_ERRATUM_845719 workaround for Brahma-B53 core
From
Date
On 10/31/19 6:21 AM, Will Deacon wrote:
> On Tue, Oct 29, 2019 at 12:16:19PM -0700, Florian Fainelli wrote:
>> From: Doug Berger <opendmb@gmail.com>
>>
>> The Broadcom Brahma-B53 core is susceptible to the issue described by
>> ARM64_ERRATUM_845719 so this commit enables the workaround to be applied
>> when executing on that core.
>>
>> Since there are now multiple entries to match, we must convert the
>> existing ARM64_ERRATUM_845719 into an erratum list.
>
> Looks fine to me, but I have to ask: are you sure you don't want to select
> any of ARM64_ERRATUM_{826319, 827319, 824069, 819472, 843419} ?

Out of this list, we are only subject to 843419 (and 845719) since I am
told that only r0p4 (inclusive) and beyond are relevant.

Good thing that you mentioned 843419 because in our downstream kernel
(4.9) this is a "static" workaround in that once enabled, it just is
unconditionally active, whereas in later kernels there is some
additional run time determination of whether this is really needed, thanks!

>
> Also, please can you update Documentation/arm64/silicon-errata.rst ?

Absolutely.
--
Florian

\
 
 \ /
  Last update: 2019-10-31 18:19    [W:0.035 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site