Messages in this thread | | | From | Ido Schimmel <> | Subject | Re: [PATCH net-next] mlxsw: Fix 64-bit division in mlxsw_sp_sb_prs_init | Date | Thu, 31 Oct 2019 06:12:15 +0000 |
| |
On Wed, Oct 30, 2019 at 09:01:52AM -0700, Nathan Chancellor wrote: > When building for 32-bit ARM, there is a link time error because of a > 64-bit division: > > ld.lld: error: undefined symbol: __aeabi_uldivmod > >>> referenced by spectrum_buffers.c > >>> net/ethernet/mellanox/mlxsw/spectrum_buffers.o:(mlxsw_sp_buffers_init) in archive drivers/built-in.a > >>> did you mean: __aeabi_uidivmod > >>> defined in: arch/arm/lib/lib.a(lib1funcs.o > > Avoid this by using div_u64, which is designed to avoid this problem. > > Fixes: bc9f6e94bcb5 ("mlxsw: spectrum_buffers: Calculate the size of the main pool") > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com> Tested-by: Ido Schimmel <idosch@mellanox.com>
Thanks, Nathan!
| |