| Date | Thu, 31 Oct 2019 12:02:04 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH v3 12/32] mtd: spi-nor: Void return type for spi_nor_clear_sr/fsr() |
| |
On Tue, 29 Oct 2019 11:17:07 +0000 <Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com> > > spi_nor_clear_sr() and spi_nor_clear_fsr() are called just in case > of errors. The callers didn't check their return value, make them > of type void. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 4a1ecf452a39..e5ed9012cd50 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -654,7 +654,7 @@ static int s3an_sr_ready(struct spi_nor *nor) > return !!(nor->bouncebuf[0] & XSR_RDY); > } > > -static int spi_nor_clear_sr(struct spi_nor *nor) > +static void spi_nor_clear_sr(struct spi_nor *nor) > { > if (nor->spimem) { > struct spi_mem_op op = > @@ -690,7 +690,7 @@ static int spi_nor_sr_ready(struct spi_nor *nor) > return !(nor->bouncebuf[0] & SR_WIP); > } > > -static int spi_nor_clear_fsr(struct spi_nor *nor) > +static void spi_nor_clear_fsr(struct spi_nor *nor) > { > if (nor->spimem) { > struct spi_mem_op op =
|