| Date | Thu, 31 Oct 2019 11:58:56 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH v3 10/32] mtd: spi-nor: Pointer parameter for CR in spi_nor_read_cr() |
| |
On Tue, 29 Oct 2019 11:17:04 +0000 <Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Let the callers pass the pointer to the DMA-able buffer where > the value of the Configuration Register will be written. This way we > avoid the casts between int and u8, which can be confusing. > > Callers stop compare the return value of spi_nor_read_cr() with negative, > spi_nor_read_cr() returns 0 on success and -errno otherwise. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
There's just this &nor->bouncebuf[0] that I'd prefer to be turned into nor->bouncebuf if you're okay.
|