lkml.org 
[lkml]   [2019]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 12/18] USB: legousbtower: fix a signedness bug in tower_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit fd47a417e75e2506eb3672ae569b1c87e3774155 ]

    The problem is that sizeof() is unsigned long so negative error codes
    are type promoted to high positive values and the condition becomes
    false.

    Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20191011141115.GA4521@mwanda
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/misc/legousbtower.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
    index f56307059d48c..7cac3ee09b09d 100644
    --- a/drivers/usb/misc/legousbtower.c
    +++ b/drivers/usb/misc/legousbtower.c
    @@ -898,7 +898,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
    get_version_reply,
    sizeof(*get_version_reply),
    1000);
    - if (result < sizeof(*get_version_reply)) {
    + if (result != sizeof(*get_version_reply)) {
    if (result >= 0)
    result = -EIO;
    dev_err(idev, "get version request failed: %d\n", result);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-10-30 16:59    [W:2.818 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site