lkml.org 
[lkml]   [2019]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.3 14/81] ASoC: SOF: Intel: hda: fix warnings during FW load
    Date
    From: Kai Vehmanen <kai.vehmanen@linux.intel.com>

    [ Upstream commit 4ff5f6439fe69624e8f7d559915e9b54a6477684 ]

    The "snd_pcm_substream" handle was not initialized properly
    in hda-loader.c for firmware load.

    When the HDA DMAs were used to load the firmware,
    the interrupts related to firmware load also triggered
    calls to snd_sof_pcm_period_elapsed() on a non-existent ALSA
    PCM stream.

    This caused runtime kernel warnings from
    pcm_lib.c:snd_pcm_period_elapsed().

    Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Link: https://lore.kernel.org/r/20190927200538.660-11-pierre-louis.bossart@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/sof/intel/hda-loader.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c
    index 6427f0b3a2f11..65c2af3fcaab7 100644
    --- a/sound/soc/sof/intel/hda-loader.c
    +++ b/sound/soc/sof/intel/hda-loader.c
    @@ -44,6 +44,7 @@ static int cl_stream_prepare(struct snd_sof_dev *sdev, unsigned int format,
    return -ENODEV;
    }
    hstream = &dsp_stream->hstream;
    + hstream->substream = NULL;

    /* allocate DMA buffer */
    ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-10-30 16:51    [W:5.131 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site