Messages in this thread | | | Date | Wed, 30 Oct 2019 12:44:31 +0100 | From | David Sterba <> | Subject | Re: [PATCH v3] fs: affs: fix a memory leak in affs_remount |
| |
On Wed, Oct 02, 2019 at 04:52:37PM -0500, Navid Emamdoost wrote: > In affs_remount if data is provided it is duplicated into new_opts. > The allocated memory for new_opts is only released if pare_options fail. > But the variable is not used anywhere. So the new_opts should be > removed. > > Fixes: c8f33d0bec99 ("affs: kstrdup() memory handling") > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > --- > Changes in v2: > -- fix typo > Changes in v3: > -- remove the call to kstrdup, as new_opts is not used anymore.
Added it to affs queue. There are still typos in the changelog and this was pointed out, and v3 lacks the explanations I replied to v2. I'll fix it up.
| |