lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 146/313] perf report: Fix --ns time sort key output
    Date
    From: Andi Kleen <ak@linux.intel.com>

    [ Upstream commit 3dab6ac080dcd7f71cb9ceb84ad7dafecd6f7c07 ]

    If the user specified --ns, the column to print the sort time stamp
    wasn't wide enough to actually print the full nanoseconds.

    Widen the time key column width when --ns is specified.

    Before:

    % perf record -a sleep 1
    % perf report --sort time,overhead,symbol --stdio --ns
    ...
    2.39% 187851.10000 [k] smp_call_function_single - -
    1.53% 187851.10000 [k] intel_idle - -
    0.59% 187851.10000 [.] __wcscmp_ifunc - -
    0.33% 187851.10000 [.] 0000000000000000 - -
    0.28% 187851.10000 [k] cpuidle_enter_state - -

    After:

    % perf report --sort time,overhead,symbol --stdio --ns
    ...
    2.39% 187851.100000000 [k] smp_call_function_single - -
    1.53% 187851.100000000 [k] intel_idle - -
    0.59% 187851.100000000 [.] __wcscmp_ifunc - -
    0.33% 187851.100000000 [.] 0000000000000000 - -
    0.28% 187851.100000000 [k] cpuidle_enter_state - -

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Link: http://lkml.kernel.org/r/20190823210338.12360-2-andi@firstfloor.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/util/hist.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
    index 7ace7a10054d8..966c248d6a3a1 100644
    --- a/tools/perf/util/hist.c
    +++ b/tools/perf/util/hist.c
    @@ -193,7 +193,10 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
    hists__new_col_len(hists, HISTC_MEM_LVL, 21 + 3);
    hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);
    hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);
    - hists__new_col_len(hists, HISTC_TIME, 12);
    + if (symbol_conf.nanosecs)
    + hists__new_col_len(hists, HISTC_TIME, 16);
    + else
    + hists__new_col_len(hists, HISTC_TIME, 12);

    if (h->srcline) {
    len = MAX(strlen(h->srcline), strlen(sort_srcline.se_header));
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-03 18:31    [W:4.572 / U:0.852 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site