lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 149/211] ALSA: firewire-tascam: handle error code when getting current source of clock
    Date
    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit 2617120f4de6d0423384e0e86b14c78b9de84d5a upstream.

    The return value of snd_tscm_stream_get_clock() is ignored. This commit
    checks the value and handle error.

    Fixes: e453df44f0d6 ("ALSA: firewire-tascam: add PCM functionality")
    Cc: <stable@vger.kernel.org> # v4.4+
    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Link: https://lore.kernel.org/r/20190910135152.29800-2-o-takashi@sakamocchi.jp
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/firewire/tascam/tascam-pcm.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/sound/firewire/tascam/tascam-pcm.c
    +++ b/sound/firewire/tascam/tascam-pcm.c
    @@ -57,6 +57,9 @@ static int pcm_open(struct snd_pcm_subst
    goto err_locked;

    err = snd_tscm_stream_get_clock(tscm, &clock);
    + if (err < 0)
    + goto err_locked;
    +
    if (clock != SND_TSCM_CLOCK_INTERNAL ||
    amdtp_stream_pcm_running(&tscm->rx_stream) ||
    amdtp_stream_pcm_running(&tscm->tx_stream)) {

    \
     
     \ /
      Last update: 2019-10-03 18:22    [W:4.068 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site