lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 031/211] leds: leds-lp5562 allow firmware files up to the maximum length
    Date
    From: Nick Stoughton <nstoughton@logitech.com>

    [ Upstream commit ed2abfebb041473092b41527903f93390d38afa7 ]

    Firmware files are in ASCII, using 2 hex characters per byte. The
    maximum length of a firmware string is therefore

    16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64

    Fixes: ff45262a85db ("leds: add new LP5562 LED driver")
    Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/leds-lp5562.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
    index 2a9009fe5545d..18edc8bdc9f77 100644
    --- a/drivers/leds/leds-lp5562.c
    +++ b/drivers/leds/leds-lp5562.c
    @@ -263,7 +263,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip)
    {
    const struct firmware *fw = chip->fw;

    - if (fw->size > LP5562_PROGRAM_LENGTH) {
    + /*
    + * the firmware is encoded in ascii hex character, with 2 chars
    + * per byte
    + */
    + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
    dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
    fw->size);
    return;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-03 18:18    [W:4.751 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site