lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5.2 078/313] RAS: Fix prototype warnings
On Thu, Oct 03, 2019 at 06:45:27PM +0200, Borislav Petkov wrote:
> On Thu, Oct 03, 2019 at 05:50:56PM +0200, Greg Kroah-Hartman wrote:
> > From: Valdis Klētnieks <valdis.kletnieks@vt.edu>
> >
> > [ Upstream commit 0a54b809a3a2c31e1055b45b03708eb730222be1 ]
> >
> > When building with C=2 and/or W=1, legitimate warnings are issued about
> > missing prototypes:
> >
> > CHECK drivers/ras/debugfs.c
> > drivers/ras/debugfs.c:4:15: warning: symbol 'ras_debugfs_dir' was not declared. Should it be static?
> > drivers/ras/debugfs.c:8:5: warning: symbol 'ras_userspace_consumers' was not declared. Should it be static?
> > drivers/ras/debugfs.c:38:12: warning: symbol 'ras_add_daemon_trace' was not declared. Should it be static?
> > drivers/ras/debugfs.c:54:13: warning: symbol 'ras_debugfs_init' was not declared. Should it be static?
> > CC drivers/ras/debugfs.o
> > drivers/ras/debugfs.c:8:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
> > 8 | int ras_userspace_consumers(void)
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > drivers/ras/debugfs.c:38:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
> > 38 | int __init ras_add_daemon_trace(void)
> > | ^~~~~~~~~~~~~~~~~~~~
> > drivers/ras/debugfs.c:54:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
> > 54 | void __init ras_debugfs_init(void)
> > | ^~~~~~~~~~~~~~~~
> >
> > Provide the proper includes.
> >
> > [ bp: Take care of the same warnings for cec.c too. ]
> >
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Cc: linux-edac@vger.kernel.org
> > Cc: x86@kernel.org
> > Link: http://lkml.kernel.org/r/7168.1565218769@turing-police
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> > drivers/ras/cec.c | 1 +
> > drivers/ras/debugfs.c | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> > index f5795adc5a6e1..8037c490f3ba7 100644
> > --- a/drivers/ras/cec.c
> > +++ b/drivers/ras/cec.c
> > @@ -1,6 +1,7 @@
> > // SPDX-License-Identifier: GPL-2.0
> > #include <linux/mm.h>
> > #include <linux/gfp.h>
> > +#include <linux/ras.h>
> > #include <linux/kernel.h>
> > #include <linux/workqueue.h>
> >
> > diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
> > index 9c1b717efad86..0d4f985afbf37 100644
> > --- a/drivers/ras/debugfs.c
> > +++ b/drivers/ras/debugfs.c
> > @@ -1,5 +1,7 @@
> > // SPDX-License-Identifier: GPL-2.0-only
> > #include <linux/debugfs.h>
> > +#include <linux/ras.h>
> > +#include "debugfs.h"
> >
> > struct dentry *ras_debugfs_dir;
> >
> > --
>
> Definitely not stable material.

Agreed, I'll go drop it from everywhere, sorry about that.

greg k-h

\
 
 \ /
  Last update: 2019-10-03 20:19    [W:0.216 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site