lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 051/129] ALSA: hda - Show the fatal CORB/RIRB error more clearly
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit dd65f7e19c6961ba6a69f7c925021b7a270cb950 ]

    The last fallback of CORB/RIRB communication error recovery is to turn
    on the single command mode, and this last resort usually means that
    something is really screwed up. Instead of a normal dev_err(), show
    the error more clearly with dev_WARN() with the caller stack trace.

    Also, show the bus-reset fallback also as an error, too.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_controller.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
    index 85dbe2420248d..c5e82329348b3 100644
    --- a/sound/pci/hda/hda_controller.c
    +++ b/sound/pci/hda/hda_controller.c
    @@ -866,10 +866,13 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,
    */
    if (hbus->allow_bus_reset && !hbus->response_reset && !hbus->in_reset) {
    hbus->response_reset = 1;
    + dev_err(chip->card->dev,
    + "No response from codec, resetting bus: last cmd=0x%08x\n",
    + bus->last_cmd[addr]);
    return -EAGAIN; /* give a chance to retry */
    }

    - dev_err(chip->card->dev,
    + dev_WARN(chip->card->dev,
    "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",
    bus->last_cmd[addr]);
    chip->single_cmd = 1;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-03 19:39    [W:2.225 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site