lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 030/211] dmaengine: bcm2835: Print error in case setting DMA mask fails
    Date
    From: Stefan Wahren <wahrenst@gmx.net>

    [ Upstream commit 72503b25ee363827aafffc3e8d872e6a92a7e422 ]

    During enabling of the RPi 4, we found out that the driver doesn't provide
    a helpful error message in case setting DMA mask fails. So add one.

    Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
    Link: https://lore.kernel.org/r/1563297318-4900-1-git-send-email-wahrenst@gmx.net
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/bcm2835-dma.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
    index 2b11d967acd02..9d782cc95c6a0 100644
    --- a/drivers/dma/bcm2835-dma.c
    +++ b/drivers/dma/bcm2835-dma.c
    @@ -898,8 +898,10 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
    pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;

    rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    - if (rc)
    + if (rc) {
    + dev_err(&pdev->dev, "Unable to set DMA mask\n");
    return rc;
    + }

    od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL);
    if (!od)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-03 19:27    [W:4.265 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site