lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 042/344] regulator: lm363x: Fix off-by-one n_voltages for lm3632 ldo_vpos/ldo_vneg
    Date
    From: Axel Lin <axel.lin@ingics.com>

    [ Upstream commit 1e2cc8c5e0745b545d4974788dc606d678b6e564 ]

    According to the datasheet https://www.ti.com/lit/ds/symlink/lm3632a.pdf
    Table 20. VPOS Bias Register Field Descriptions VPOS[5:0]
    Sets the Positive Display Bias (LDO) Voltage (50 mV per step)
    000000: 4 V
    000001: 4.05 V
    000010: 4.1 V
    ....................
    011101: 5.45 V
    011110: 5.5 V (Default)
    011111: 5.55 V
    ....................
    100111: 5.95 V
    101000: 6 V
    Note: Codes 101001 to 111111 map to 6 V

    The LM3632_LDO_VSEL_MAX should be 0b101000 (0x28), so the maximum voltage
    can match the datasheet.

    Fixes: 3a8d1a73a037 ("regulator: add LM363X driver")
    Signed-off-by: Axel Lin <axel.lin@ingics.com>
    Link: https://lore.kernel.org/r/20190626132632.32629-1-axel.lin@ingics.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/lm363x-regulator.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
    index 5647e2f97ff8d..e4a27d63bf901 100644
    --- a/drivers/regulator/lm363x-regulator.c
    +++ b/drivers/regulator/lm363x-regulator.c
    @@ -30,7 +30,7 @@

    /* LM3632 */
    #define LM3632_BOOST_VSEL_MAX 0x26
    -#define LM3632_LDO_VSEL_MAX 0x29
    +#define LM3632_LDO_VSEL_MAX 0x28
    #define LM3632_VBOOST_MIN 4500000
    #define LM3632_VLDO_MIN 4000000

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-10-03 19:05    [W:4.381 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site