lkml.org 
[lkml]   [2019]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 253/313] ASoC: Intel: Fix use of potentially uninitialized variable
    Date
    From: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>

    commit 810f3b860850148788fc1ed8a6f5f807199fed65 upstream.

    If ipc->ops.reply_msg_match is NULL, we may end up using uninitialized
    mask value.

    reported by smatch:
    sound/soc/intel/common/sst-ipc.c:266 sst_ipc_reply_find_msg() error: uninitialized symbol 'mask'.

    Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>
    Link: https://lore.kernel.org/r/20190827141712.21015-3-amadeuszx.slawinski@linux.intel.com
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/intel/common/sst-ipc.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/sound/soc/intel/common/sst-ipc.c
    +++ b/sound/soc/intel/common/sst-ipc.c
    @@ -222,6 +222,8 @@ struct ipc_message *sst_ipc_reply_find_m

    if (ipc->ops.reply_msg_match != NULL)
    header = ipc->ops.reply_msg_match(header, &mask);
    + else
    + mask = (u64)-1;

    if (list_empty(&ipc->rx_list)) {
    dev_err(ipc->dev, "error: rx list empty but received 0x%llx\n",

    \
     
     \ /
      Last update: 2019-10-03 18:35    [W:3.280 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site