Messages in this thread | | | From | John Stultz <> | Date | Tue, 29 Oct 2019 11:26:01 -0700 | Subject | Re: [PATCH v4 8/9] dt-bindings: usb: generic: Add role-switch-default-host binding |
| |
On Tue, Oct 29, 2019 at 2:23 AM Felipe Balbi <balbi@kernel.org> wrote: > John Stultz <john.stultz@linaro.org> writes: > > > Add binding to configure the default role the controller > > assumes is host mode when the usb role is USB_ROLE_NONE. > > ... > > + - role-switch-default-host: boolean, indicating if usb-role-switch is enabled > > + the device default operation mode of controller while > > + usb role is USB_ROLE_NONE is host mode. If this is not > > + set or false, it will be assumed the default is device > > + mode. > > Do we also need a role-switch-default-peripheral? Would it be better to > have a single role-switch-default property which accepts "host" or > "peripheral" arguments?
I guess the standard default is peripheral, so this differentiated from that, but I agree it might be more forward thinking to let it specify a type argument in case there is another option in the future.
I'll rework this.
Thanks again for the review and feedback! -john
| |