Messages in this thread | | | Date | Tue, 29 Oct 2019 08:35:26 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2] stacktrace: don't skip first entry on noncurrent tasks |
| |
On Tue, Oct 29, 2019 at 08:19:44AM +0100, Jiri Slaby wrote: > When doing cat /proc/<PID>/stack, the output is missing the first entry. > When the current code walks the stack starting in stack_trace_save_tsk, > it skips all scheduler functions (that's OK) plus one more function. But > this one function should be skipped only for the 'current' task as it is > stack_trace_save_tsk proper. > > The original code (before the common infrastructure) skipped one > function only for the 'current' task -- see save_stack_trace_tsk before > 3599fe12a125. So do so also in the new infrastructure now. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Fixes: 214d8ca6ee85 ("stacktrace: Provide common infrastructure") > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > --- > > Notes: > [v2] add the same for the !CONFIG_ARCH_STACKWALK case
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |