lkml.org 
[lkml]   [2019]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup
Hi Saurav,

Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Mon, 28 Oct 2019
23:43:01 +0530:

> Remove multiple kfree statement from phram_setup() in phram.c
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---

Here you should add a changelog with the changes you have done since
the last version.

Also when formatting the patch use -v <x> to add a version prefix
into the title, like [PATCH v<x>].

> drivers/mtd/devices/phram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index c467286ca007..38f95a1517ac 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -243,22 +243,22 @@ static int phram_setup(const char *val)
>
> ret = parse_num64(&start, token[1]);
> if (ret) {
> - kfree(name);
> parse_err("illegal start address\n");
> + goto free_nam;

s/nam/name

> }
>
> ret = parse_num64(&len, token[2]);
> if (ret) {
> - kfree(name);
> parse_err("illegal device length\n");
> + goto free_nam;
> }
>
> ret = register_device(name, start, len);
> if (!ret)
> pr_info("%s device: %#llx at %#llx\n", name, len, start);
> - else
> - kfree(name);
>
> +free_nam:
> + kfree(name);
> return ret;
> }
>

Thanks,
Miquèl

\
 
 \ /
  Last update: 2019-10-29 12:23    [W:0.043 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site