lkml.org 
[lkml]   [2019]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 5/7] perf report: Sort by sampled cycles percent per block for stdio
    On Mon, Oct 28, 2019 at 09:33:28AM +0800, Jin Yao wrote:
    > It would be useful to support sorting for all blocks by the
    > sampled cycles percent per block. This is useful to concentrate
    > on the globally hottest blocks.
    >
    > This patch implements a new option "--total-cycles" which sorts
    > all blocks by 'Sampled Cycles%'. The 'Sampled Cycles%' is the
    > percent:
    >
    > percent = block sampled cycles aggregation / total sampled cycles
    >
    > Note that, this patch only supports "--stdio" mode.
    >
    > For example,
    >
    > perf record -b ./div
    > perf report --total-cycles --stdio
    >
    > # To display the perf.data header info, please use --header/--header-only options.
    > #
    > #
    > # Total Lost Samples: 0
    > #
    > # Samples: 2M of event 'cycles'
    > # Event count (approx.): 2753248
    > #
    > # Sampled Cycles% Sampled Cycles Avg Cycles% Avg Cycles [Program Block Range] Shared Object
    > # ............... .............. ........... .......... ................................................................. ....................
    > #
    > 26.04% 2.8M 0.40% 18 [div.c:42 -> div.c:39] div
    > 15.17% 1.2M 0.16% 7 [random_r.c:357 -> random_r.c:380] libc-2.27.so
    > 5.11% 402.0K 0.04% 2 [div.c:27 -> div.c:28] div
    > 4.87% 381.6K 0.04% 2 [random.c:288 -> random.c:291] libc-2.27.so
    > 4.53% 381.0K 0.04% 2 [div.c:40 -> div.c:40] div
    > 3.85% 300.9K 0.02% 1 [div.c:22 -> div.c:25] div
    > 3.08% 241.1K 0.02% 1 [rand.c:26 -> rand.c:27] libc-2.27.so
    > 3.06% 240.0K 0.02% 1 [random.c:291 -> random.c:291] libc-2.27.so
    > 2.78% 215.7K 0.02% 1 [random.c:298 -> random.c:298] libc-2.27.so
    > 2.52% 198.3K 0.02% 1 [random.c:293 -> random.c:293] libc-2.27.so
    > 2.36% 184.8K 0.02% 1 [rand.c:28 -> rand.c:28] libc-2.27.so
    > 2.33% 180.5K 0.02% 1 [random.c:295 -> random.c:295] libc-2.27.so
    > 2.28% 176.7K 0.02% 1 [random.c:295 -> random.c:295] libc-2.27.so
    > 2.20% 168.8K 0.02% 1 [rand@plt+0 -> rand@plt+0] div
    > 1.98% 158.2K 0.02% 1 [random_r.c:388 -> random_r.c:388] libc-2.27.so
    > 1.57% 123.3K 0.02% 1 [div.c:42 -> div.c:44] div
    > 1.44% 116.0K 0.42% 19 [random_r.c:357 -> random_r.c:394] libc-2.27.so
    > 0.25% 182.5K 0.02% 1 [random_r.c:388 -> random_r.c:391] libc-2.27.so
    > 0.00% 48 1.07% 48 [x86_pmu_enable+284 -> x86_pmu_enable+298] [kernel.kallsyms]
    > 0.00% 74 1.64% 74 [vm_mmap_pgoff+0 -> vm_mmap_pgoff+92] [kernel.kallsyms]
    > 0.00% 73 1.62% 73 [vm_mmap+0 -> vm_mmap+48] [kernel.kallsyms]
    > 0.00% 63 0.69% 31 [up_write+0 -> up_write+34] [kernel.kallsyms]
    > 0.00% 13 0.29% 13 [setup_arg_pages+396 -> setup_arg_pages+413] [kernel.kallsyms]
    > 0.00% 3 0.07% 3 [setup_arg_pages+418 -> setup_arg_pages+450] [kernel.kallsyms]
    > 0.00% 616 6.84% 308 [security_mmap_file+0 -> security_mmap_file+72] [kernel.kallsyms]
    > 0.00% 23 0.51% 23 [security_mmap_file+77 -> security_mmap_file+87] [kernel.kallsyms]
    > 0.00% 4 0.02% 1 [sched_clock+0 -> sched_clock+4] [kernel.kallsyms]
    > 0.00% 4 0.02% 1 [sched_clock+9 -> sched_clock+12] [kernel.kallsyms]
    > 0.00% 1 0.02% 1 [rcu_nmi_exit+0 -> rcu_nmi_exit+9] [kernel.kallsyms]
    >
    > v4:
    > ---
    > 1. Use new option '--total-cycles' to replace
    > '-s total_cycles' in v3.
    >
    > 2. Move block info collection out of block info
    > printing.
    >
    > v3:
    > ---
    > 1. Use common function block_info__process_sym to
    > process the blocks per symbol.
    >
    > 2. Remove the nasty hack for skipping calculation
    > of column length
    >
    > 3. Some minor cleanup
    >
    > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
    > ---
    > tools/perf/Documentation/perf-report.txt | 11 ++
    > tools/perf/builtin-report.c | 125 ++++++++++++++++++++++-
    > tools/perf/ui/stdio/hist.c | 22 ++++
    > tools/perf/util/hist.c | 4 +
    > tools/perf/util/symbol_conf.h | 1 +
    > 5 files changed, 160 insertions(+), 3 deletions(-)
    >
    > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
    > index 7315f155803f..8dbe2119686a 100644
    > --- a/tools/perf/Documentation/perf-report.txt
    > +++ b/tools/perf/Documentation/perf-report.txt
    > @@ -525,6 +525,17 @@ include::itrace.txt[]
    > Configure time quantum for time sort key. Default 100ms.
    > Accepts s, us, ms, ns units.
    >
    > +--total-cycles::
    > + When --total-cycles is specified, it supports sorting for all blocks by
    > + 'Sampled Cycles%'. This is useful to concentrate on the globally hottest
    > + blocks. In output, there are some new columns:
    > +
    > + 'Sampled Cycles%' - block sampled cycles aggregation / total sampled cycles
    > + 'Sampled Cycles' - block sampled cycles aggregation
    > + 'Avg Cycles%' - block average sampled cycles / sum of total block average
    > + sampled cycles
    > + 'Avg Cycles' - block average sampled cycles
    > +
    > include::callchain-overhead-calculation.txt[]
    >
    > SEE ALSO
    > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    > index cdb436d6e11f..a687d9e4aeca 100644
    > --- a/tools/perf/builtin-report.c
    > +++ b/tools/perf/builtin-report.c
    > @@ -51,6 +51,7 @@
    > #include "util/util.h" // perf_tip()
    > #include "ui/ui.h"
    > #include "ui/progress.h"
    > +#include "util/block-info.h"
    >
    > #include <dlfcn.h>
    > #include <errno.h>
    > @@ -67,6 +68,12 @@
    > #include <unistd.h>
    > #include <linux/mman.h>
    >
    > +struct block_report {
    > + struct block_hist block_hist;
    > + u64 block_cycles;
    > + struct block_fmt block_fmts[PERF_HPP_REPORT__BLOCK_MAX_INDEX];

    no need for the 'block_' prefix for the members

    also please put this and all the new functions under block_info.c

    thanks,
    jirka

    \
     
     \ /
      Last update: 2019-10-29 10:29    [W:4.034 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site