Messages in this thread | | | Date | Tue, 29 Oct 2019 09:54:01 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v11 4/7] drm/sun4i: dsi: Handle bus clock explicitly |
| |
On Tue, Oct 29, 2019 at 04:03:56AM +0530, Jagan Teki wrote: > > > explicit handling of common clock would require since the A64 > > > doesn't need to mention the clock-names explicitly in dts since it > > > support only one bus clock. > > > > > > Also pass clk_id NULL instead "bus" to regmap clock init function > > > since the single clock variants no need to mention clock-names > > > explicitly. > > > > You don't need explicit clock handling. Passing NULL as the argument > > in regmap_init_mmio_clk will make it use the first clock, which is the > > bus clock. > > Indeed I tried that, since NULL clk_id wouldn't enable the bus clock > during regmap_mmio_gen_context code, passing NULL triggering vblank > timeout.
There's a bunch of users of NULL in tree, so finding out why NULL doesn't work is the way forward.
Maxime [unhandled content-type:application/pgp-signature] | |