Messages in this thread | | | Subject | Re: [RFC 1/2] vhost: IFC VF hardware operation layer | From | "Zhu, Lingshan" <> | Date | Tue, 29 Oct 2019 15:36:22 +0800 |
| |
On 10/16/2019 10:06 AM, Stephen Hemminger wrote: > On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan > <lingshan.zhu@intel.com> wrote: >> + IFC_INFO(&dev->dev, "PCI capability mapping:\n" + "common cfg: >> %p\n" + "notify base: %p\n" + "isr cfg: %p\n" + "device cfg: %p\n" + >> "multiplier: %u\n", + hw->common_cfg, + hw->notify_base, + hw->isr, + >> hw->dev_cfg, + hw->notify_off_multiplier); > Since kernel messages go to syslog, syslog does not handle multi-line > messages very well. This should be a single line. Also, this is the > kind of message that should be at the debug level; something that is > useful to the driver developers but not something that needs to be > filling up every end users log. Hi Stephen
Thanks for your comments, I have changed them in RFC V2, will send the patchset soon. Thanks, BR Zhu Lingshan
| |