Messages in this thread | | | Subject | Re: [PATCH net-next v2 4/4] bonding: balance ICMP echoes in layer3+4 mode | From | Eric Dumazet <> | Date | Tue, 29 Oct 2019 16:14:53 -0700 |
| |
On 10/29/19 4:03 PM, Matteo Croce wrote:
> Hi Eric, > > this would work for locally generated echoes, but what about forwarded packets? > The point behind my changeset is to provide consistent results within > a session by using the same path for request and response, > but avoid all sessions flowing to the same path. > This should resemble what happens with TCP and UDP: different > connections, different port, probably a different path. And by doing > this in the flow dissector, other applications could benefit it.
In principle it is fine, but I was not sure of overall impact of your change on performance for 99.9% of packets that are not ICMP :)
| |