This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu Apr 25 09:08:48 2024 >From mailfetcher Mon Oct 28 21:59:18 2019 Envelope-to: lkml@grols.ch Delivery-date: Mon, 28 Oct 2019 21:59:17 +0100 Received: from stout.grols.ch [195.201.141.146] by 72459556e3a9 with IMAP (fetchmail-6.3.26) for (single-drop); Mon, 28 Oct 2019 21:59:18 +0100 (CET) Received: from vger.kernel.org ([209.132.180.67]) by stout.grols.ch with esmtp (Exim 4.89) (envelope-from ) id 1iPC6f-0007Rh-6q for lkml@grols.ch; Mon, 28 Oct 2019 21:59:17 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388481AbfJ1U7B (ORCPT ); Mon, 28 Oct 2019 16:59:01 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43585 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbfJ1U7B (ORCPT ); Mon, 28 Oct 2019 1 Received: by mail-pg1-f195.google.com with SMTP id l24so7761747pgh.10; Mon, 28 Oct 2019 13:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=fnnx0BsXF5mY3wVLlFvOOcZalsRDnZJxgNUMzEL+TXc=; b=Yk20A5keXvFNXwedn9yOf X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=fnnx0BsXF5mY3wVLlFvOOcZalsRDnZJxgNUMzEL+TXc=; b=IY X-Gm-Message-State: APjAAAUYfrDmAlUcjVpkj6vhYQGPd4JRk1+os6ISDPsorgGXDS977pTG 3IZinikWXH9bG2GM4tZ+xQ4= X-Google-Smtp-Source: APXvYqzOfsOzxOd5zhs7OfjrYKSGqNPmtvNSgnOaUezBHTakTHhWRXRzfTpDVE4aYOnkBHu50sHUyA== X-Received: by 2002:a62:e508:: with SMTP id n8mr23443365pff.111.1572296340334; Mon, 28 Oct 2019 13:59:00 -0700 (PDT) Received: from saurav ([27.62.167.137]) by smtp.gmail.com with ESMTPSA id c8sm383708pjo.1.2019.10.28.13.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 13:58:59 -0700 (PDT) Date: Tue, 29 Oct 2019 02:28:53 +0530 From: Saurav Girepunje To: Kai.Makisara@kolumbus.fi, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Subject: [PATCH] scsi: st.c: Remove unneeded variable. Message-Id: <20191028205853.GA29719@saurav> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: pass client-ip=209.132.180.67; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org variable "result" is not modified in function st_release(). So remove it. Signed-off-by: Saurav Girepunje --- drivers/scsi/st.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index e3266a64a477..bddabecfbe5c 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -1455,7 +1455,6 @@ static int st_flush(struct file *filp, fl_owner_t id) accessing this tape. */ static int st_release(struct inode *inode, struct file *filp) { - int result = 0; struct scsi_tape *STp = filp->private_data; if (STp->door_locked == ST_LOCKED_AUTO) @@ -1468,7 +1467,7 @@ static int st_release(struct inode *inode, struct file *filp) scsi_autopm_put_device(STp->device); scsi_tape_put(STp); - return result; + return 0; } /* The checks common to both reading and writing */ -- 2.20.1