Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH 18/46] ARM: pxa: corgi: use gpio descriptors for audio | Date | Mon, 28 Oct 2019 21:56:56 +0100 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > @@ -41,6 +40,8 @@ > static int corgi_jack_func; > static int corgi_spk_func; > > +struct gpio_desc *gpiod_mute_l, *gpiod_mute_r, *gpiod_apm_on, > *gpiod_mic_bias; Can't this be static ?
Otherwise : Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
-- Robert
| |