Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v2] cpufreq: powernv: fix stack bloat and NR_CPUS limitation | Date | Mon, 28 Oct 2019 16:26:16 +0100 |
| |
On Friday, October 18, 2019 7:07:12 AM CET Viresh Kumar wrote: > On 17-10-19, 21:55, John Hubbard wrote: > > The following build warning occurred on powerpc 64-bit builds: > > > > drivers/cpufreq/powernv-cpufreq.c: In function 'init_chip_info': > > drivers/cpufreq/powernv-cpufreq.c:1070:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > This is due to putting 1024 bytes on the stack: > > > > unsigned int chip[256]; > > > > ...and while looking at this, it also has a bug: it fails with a stack > > overrun, if CONFIG_NR_CPUS > 256. > > > > Fix both problems by dynamically allocating based on CONFIG_NR_CPUS. > > > > Fixes: 053819e0bf840 ("cpufreq: powernv: Handle throttling due to Pmax capping at chip level") > > Cc: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> > > Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > > Cc: linux-pm@vger.kernel.org > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> > > --- > > > > Changes since v1: includes Viresh's review commit fixes. > > > > drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > >
Applying as 5.5 material, thanks!
| |