Messages in this thread | | | Subject | Re: [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog | From | Xingyu Chen <> | Date | Mon, 28 Oct 2019 16:35:18 +0800 |
| |
Hi, Rob
On 2019/10/26 4:30, Rob Herring wrote: > On Fri, Oct 25, 2019 at 02:13:02PM +0800, Xingyu Chen wrote: >> The binding targets the Meson-A/C series compatible SoCs, in which the >> watchdog registers are in secure world. >> >> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com> >> --- >> .../bindings/watchdog/amlogic,meson-sec-wdt.yaml | 34 ++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml >> >> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml >> new file mode 100644 >> index 00000000..0bbc807 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml >> @@ -0,0 +1,34 @@ >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +# Copyright (c) 2019 Amlogic, Inc >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic Meson Secure Watchdog Timer >> + >> +maintainers: >> + - Xingyu Chen <xingyu.chen@amlogic.com> >> + >> +description: |+ >> + Secure Watchdog Timer used in Meson-A/C series Compatible SoCs >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-sec-wdt > > If there are no other properties, then you don't need this. Just have > the secure firmware driver instantiate the watchdog. I'am very sorry i don't understand how to initialize the watchdog driver if the compatible property is removed, Could you give me more suggestions or examples ? Thank you very much.
> >> + >> + secure-monitor: >> + description: phandle to the secure-monitor node >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> +required: >> + - compatible >> + - secure-monitor >> + >> +examples: >> + - | >> + watchdog { >> + compatible = "amlogic,meson-sec-wdt"; >> + secure-monitor = <&sm>; >> + }; >> -- >> 2.7.4 >> > > . >
| |