Messages in this thread | | | Subject | Re: [PATCH] net: hisilicon: Fix ping latency when deal with high throughput | From | Jiangfeng Xiao <> | Date | Mon, 28 Oct 2019 09:27:12 +0800 |
| |
On 2019/10/27 2:22, David Miller wrote: > From: Jiangfeng Xiao <xiaojiangfeng@huawei.com> > Date: Sat, 26 Oct 2019 16:49:39 +0800 > >> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c >> index ad6d912..78f338a 100644 >> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c >> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c >> @@ -575,7 +575,7 @@ static int hip04_rx_poll(struct napi_struct *napi, int budget) >> struct hip04_priv *priv = container_of(napi, struct hip04_priv, napi); >> struct net_device *ndev = priv->ndev; >> struct net_device_stats *stats = &ndev->stats; >> - unsigned int cnt = hip04_recv_cnt(priv); >> + static unsigned int cnt_remaining; > > There is no way a piece of software state should be system wide, this is > a per device instance value. > > . > Thank you for your guidance, I will fix it in v2.
| |