lkml.org 
[lkml]   [2019]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 195/197] of: reserved_mem: add missing of_node_put() for proper ref-counting
    Date
    From: Chris Goldsworthy <cgoldswo@codeaurora.org>

    commit 5dba51754b04a941a1064f584e7a7f607df3f9bc upstream.

    Commit d698a388146c ("of: reserved-memory: ignore disabled memory-region
    nodes") added an early return in of_reserved_mem_device_init_by_idx(), but
    didn't call of_node_put() on a device_node whose ref-count was incremented
    in the call to of_parse_phandle() preceding the early exit.

    Fixes: d698a388146c ("of: reserved-memory: ignore disabled memory-region nodes")
    Signed-off-by: Chris Goldsworthy <cgoldswo@codeaurora.org>
    Cc: stable@vger.kernel.org
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/of/of_reserved_mem.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/of/of_reserved_mem.c
    +++ b/drivers/of/of_reserved_mem.c
    @@ -324,8 +324,10 @@ int of_reserved_mem_device_init_by_idx(s
    if (!target)
    return -ENODEV;

    - if (!of_device_is_available(target))
    + if (!of_device_is_available(target)) {
    + of_node_put(target);
    return 0;
    + }

    rmem = __find_rmem(target);
    of_node_put(target);

    \
     
     \ /
      Last update: 2019-10-27 22:27    [W:4.216 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site