lkml.org 
[lkml]   [2019]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/tinydrm: Fix memroy leak in hx8357d_probe
From
Date

> +++ b/drivers/gpu/drm/tiny/hx8357d.c
> @@ -232,44 +232,49 @@ static int hx8357d_probe(struct spi_device *spi)

> + goto free_dbidev;
>
> spi_set_drvdata(spi, drm);

I got another development concern here.
Can it make sense to pass the variable “dbidev” instead of “drm”?



> +free_dbidev:
> + kfree(dbidev);


I became curious if there is a need for such a memory release at another place.
How do you think about to add this function call also to the implementation
of the function “hx8357d_remove”?

Regards,
Markus

\
 
 \ /
  Last update: 2019-10-27 20:56    [W:0.068 / U:2.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site