Messages in this thread | | | Subject | Re: [PATCH] drm/tinydrm: Fix memroy leak in hx8357d_probe | From | Markus Elfring <> | Date | Sun, 27 Oct 2019 20:55:48 +0100 |
| |
… > +++ b/drivers/gpu/drm/tiny/hx8357d.c > @@ -232,44 +232,49 @@ static int hx8357d_probe(struct spi_device *spi) … > + goto free_dbidev; > > spi_set_drvdata(spi, drm);
I got another development concern here. Can it make sense to pass the variable “dbidev” instead of “drm”?
… > +free_dbidev: > + kfree(dbidev); …
I became curious if there is a need for such a memory release at another place. How do you think about to add this function call also to the implementation of the function “hx8357d_remove”?
Regards, Markus
| |