lkml.org 
[lkml]   [2019]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2][for-next] cleanup submission path
From
Date
On 10/27/19 9:35 AM, Pavel Begunkov wrote:
> A small cleanup of very similar but diverged io_submit_sqes() and
> io_ring_submit()
>
> Pavel Begunkov (2):
> io_uring: handle mm_fault outside of submission
> io_uring: merge io_submit_sqes and io_ring_submit
>
> fs/io_uring.c | 116 ++++++++++++++------------------------------------
> 1 file changed, 33 insertions(+), 83 deletions(-)

I like the cleanups here, but one thing that seems off is the
assumption that io_sq_thread() always needs to grab the mm. If
the sqes processed are just READ/WRITE_FIXED, then it never needs
to grab the mm.

--
Jens Axboe

\
 
 \ /
  Last update: 2019-10-27 17:33    [W:0.086 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site