lkml.org 
[lkml]   [2019]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] platform/chrome: wilco_ec: Add Wilco EC keyboard backlight LEDs support
Thanks Nick for taking care of this. I just reviewed your patch
in the other thread. Also, thanks Enric for your comments.

Thanks again.
Daniel

On Thu, Oct 24, 2019 at 04:18:07PM -0600, Nick Crews wrote:
> Thanks for getting this going again Daniel. This version of
> the patch is fairly old, and after so long I've found some
> things about it that I don't like, even though I wrote it
> originally :). One of the main things was how complicated it
> was, and how there was duplicated code in core.c and the
> kbd_backlight_leds.c.
>
> Therefore, I just sent a newer version of this that simplifies
> things greatly, and addresses the feedback that Enric just gave.
> Check for that patch (it's paired with another unrelated one)
> and see what you think.
>
> Cheers,
> Nick
>
> On Thu, Oct 24, 2019 at 3:54 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> >
> > Hi Daniel,
> >
> > Some few comments, mostly nits. In general I'm fine with it.
> >
> > Thanks,
> > Enric

\
 
 \ /
  Last update: 2019-10-25 19:36    [W:0.097 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site